Fix issue #26: P0 bug: bug: run-qa-agent.sh and run-report-…#120
Fix issue #26: P0 bug: bug: run-qa-agent.sh and run-report-…#120
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #26 by making the QA and report runner scripts self-sufficient: if the ./shellforge binary isn’t present in the repo root, the scripts will build it before executing the requested command.
Changes:
- Add an on-demand
go build -o shellforge ./cmd/shellforgestep torun-qa-agent.shwhen./shellforgeis missing. - Add an on-demand
go build -o shellforge ./cmd/shellforgestep torun-report-agent.shwhen./shellforgeis missing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/run-report-agent.sh | Builds ./shellforge if missing, then runs shellforge report. |
| scripts/run-qa-agent.sh | Builds ./shellforge if missing, then runs shellforge qa. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| set -euo pipefail | ||
| cd "$(dirname "$0")/.." | ||
|
|
||
| if [[ ! -f ./shellforge ]]; then |
There was a problem hiding this comment.
The build guard only checks for file existence (-f). If ./shellforge exists but is not executable (e.g., permissions lost when copying artifacts), the script will skip the build and then exec ./shellforge ... will fail. Consider checking -x (or falling back to rebuilding/chmod) so the script self-heals in this case.
| if [[ ! -f ./shellforge ]]; then | |
| if [[ ! -x ./shellforge ]]; then |
| set -euo pipefail | ||
| cd "$(dirname "$0")/.." | ||
|
|
||
| if [[ ! -f ./shellforge ]]; then |
There was a problem hiding this comment.
The build guard only checks for file existence (-f). If ./shellforge exists but is not executable (e.g., permissions lost when copying artifacts), the script will skip the build and then exec ./shellforge ... will fail. Consider checking -x (or falling back to rebuilding/chmod) so the script self-heals in this case.
| if [[ ! -f ./shellforge ]]; then | |
| if [[ ! -x ./shellforge ]]; then |
Auto-generated by Cata via /evolve dispatch
Task: brain-26-1775283229